Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the assignment of a delivery service to a server, to respect capabilities #7878

Merged
merged 1 commit into from Dec 4, 2023

Conversation

rimashah25
Copy link
Contributor

@rimashah25 rimashah25 commented Dec 4, 2023

This PR fixes the issue of attempting to execute direct DS assignment in TP


Which Traffic Control components are affected by this PR?

  • Traffic Ops
  • Traffic Portal

What is the best way to verify this PR?

Run Traffic Ops and Traffic Portal.
Create a deliveryservice and assign a topology to it.
Now, try to assign a server independently to this DS.
Make sure that it works.

Now try the above operations with and without required capabilities on the DS, and server capabilities on the server.

If this is a bugfix, which Traffic Control versions contained the bug?

  • master

PR submission checklist

…pabilities

* adding changelog

* fixing Traffic Portal to account for the correct field names

* adding org server edge case
@rimashah25 rimashah25 marked this pull request as ready for review December 4, 2023 20:05
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (fa231d7) 65.64% compared to head (adbdd1e) 31.89%.

Files Patch % Lines
...ffic_ops_golang/deliveryservice/servers/servers.go 0.00% 13 Missing ⚠️
lib/go-tc/deliveryservice_servers.go 0.00% 1 Missing ⚠️
...ps/traffic_ops_golang/server/servers_assignment.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             master    #7878       +/-   ##
=============================================
- Coverage     65.64%   31.89%   -33.75%     
  Complexity       98       98               
=============================================
  Files           323      719      +396     
  Lines         12836    82838    +70002     
  Branches        970      970               
=============================================
+ Hits           8426    26424    +17998     
- Misses         4050    54252    +50202     
- Partials        360     2162     +1802     
Flag Coverage Δ
golib_unit 53.84% <0.00%> (?)
grove_unit 12.02% <ø> (?)
t3c_unit 5.88% <ø> (?)
traffic_monitor_unit 26.44% <ø> (?)
traffic_ops_unit 21.67% <0.00%> (?)
traffic_portal_v2 74.30% <ø> (-0.06%) ⬇️
traffic_stats_unit 10.78% <ø> (?)
unit_tests 29.22% <0.00%> (-45.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zrhoffman zrhoffman merged commit 80255a0 into apache:master Dec 4, 2023
87 checks passed
@rimashah25 rimashah25 deleted the bugfix/ds-server-capability branch December 4, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants