Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate dynamic scripted Grafana Dashboards to Scenes #7927

Merged
merged 25 commits into from
Feb 28, 2024

Conversation

ntheanh201
Copy link
Contributor

@ntheanh201 ntheanh201 commented Jan 24, 2024

  1. Upgrade to Grafana v10.2.3
  2. Migrate Scripted Dashboards to Grafana Scenes
  1. Update documentation: the way to configure Grafana and the current Traffic Portal doesn't use directly the Grafana dashboards

Which Traffic Control components are affected by this PR?

  • Traffic Stats
  • CDN in a Box

What is the best way to verify this PR?

  • Build Traffic Stats
  • Run CDN in a Box with Traffic Stats, Grafana
  • Visit Grafana server, go to Apps -> TrafficControl Grafana Scenes
  • See the dashboards

Check the images below

If this is a bugfix, which Traffic Control versions contained the bug?

PR submission checklist

@ntheanh201
Copy link
Contributor Author

Screenshot 2024-01-24 at 15 12 28 Cache Group dashboard

@ntheanh201
Copy link
Contributor Author

Screenshot 2024-01-24 at 15 12 42 Delivery Service dashboard

@ntheanh201
Copy link
Contributor Author

Screenshot 2024-01-24 at 15 13 06 Server dashboard

@ntheanh201
Copy link
Contributor Author

@jhg03a I also updated the Dockerfile of Grafana, I think you can give me some reviews

@ocket8888 ocket8888 added Traffic Stats related to Traffic Stats Traffic Portal v1 related to Traffic Portal version 1 low impact affects only a small portion of a CDN, and cannot itself break one tech debt rework due to choosing easy/limited solution cdn-in-a-box related to the Docker-based CDN-in-a-Box system labels Jan 30, 2024
@ocket8888 ocket8888 self-assigned this Feb 7, 2024
Copy link
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks fine on GitHub. I'll carve out some time tomorrow to try to spin it up and see how it actually works (#5939 permitting).

@ntheanh201
Copy link
Contributor Author

This all looks fine on GitHub. I'll carve out some time tomorrow to try to spin it up and see how it actually works (#5939 permitting).

Did you finish with checking?

@ocket8888
Copy link
Contributor

Did you finish with checking?

Sorry, no, I got busy. And then... I forgot 😅

Copy link
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to work in its own right, but even after rebasing I can't get Docker to realize the builder on this branch is newer than the one it can pull. So I'm hoping merging it to master just solves that by publishing a new builder image. If it doesn't, for some reason, CiaB runs may be broken until it's resolved (locally, in all likelihood CI would be unaffected in this scenario) - although the project itself is still buildable if done from actual scratch. I think that's unlikely to happen, but excited to find out for sure.

@ocket8888 ocket8888 merged commit 2679489 into apache:master Feb 28, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cdn-in-a-box related to the Docker-based CDN-in-a-Box system low impact affects only a small portion of a CDN, and cannot itself break one tech debt rework due to choosing easy/limited solution Traffic Portal v1 related to Traffic Portal version 1 Traffic Stats related to Traffic Stats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants