Fix incorrect display of delivery services for an ORG server #7957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add changelog code review --------- Co-authored-by: Srijeet Chatterjee <srijeet0406@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7957 +/- ##
============================================
+ Coverage 26.29% 29.23% +2.94%
Complexity 98 98
============================================
Files 738 859 +121
Lines 85719 91276 +5557
Branches 90 998 +908
============================================
+ Hits 22537 26683 +4146
- Misses 61094 62439 +1345
- Partials 2088 2154 +66
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rimashah25
added
Traffic Ops
zrhoffman
removed
the
low difficulty
rimashah25
added a commit
that referenced
this pull request
Mar 6, 2024
Co-authored-by: Chatterjee, Srijeet <srijeet_chatterjee@comcast.com> (cherry picked from commit 0839096)
rimashah25
added a commit
to rimashah25/trafficcontrol
that referenced
this pull request
Mar 20, 2024
zrhoffman
added a commit
that referenced
this pull request
Mar 20, 2024
* Update Chromedriver Versions (#7931) * Update Go version to 1.21.7 (#7935) * Update Chromedriver Versions (#7941) Update chromedriver (cherry picked from commit 8d1b4e3) * Update Go version to 1.22.0 (#7940) * Update Chromedriver Versions (#7942) Update chromedriver (cherry picked from commit 578f04e) * Update Chromedriver Versions (#7949) Update chromedriver (cherry picked from commit f91c341) * Update Chromedriver Versions (#7950) Update chromedriver (cherry picked from commit a423170) * Bump ip from 1.1.8 to 1.1.9 in /experimental/traffic-portal/build (#7945) Bumps [ip](https://github.com/indutny/node-ip) from 1.1.8 to 1.1.9. - [Commits](indutny/node-ip@v1.1.8...v1.1.9) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit 6c6eebc) * Bump es5-ext from 0.10.62 to 0.10.64 in /experimental/traffic-portal (#7951) Bumps [es5-ext](https://github.com/medikoo/es5-ext) from 0.10.62 to 0.10.64. - [Release notes](https://github.com/medikoo/es5-ext/releases) - [Changelog](https://github.com/medikoo/es5-ext/blob/main/CHANGELOG.md) - [Commits](medikoo/es5-ext@v0.10.62...v0.10.64) --- updated-dependencies: - dependency-name: es5-ext dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit e05e709) * Update Chromedriver Versions (#7954) Update chromedriver (cherry picked from commit 1464dc2) * Update Go version to 1.22.1 (#7955) Co-authored-by: asf-ci-trafficcontrol <asf-ci-trafficcontrol@users.noreply.github.com> (cherry picked from commit dc995a9) * Fix incorrect display of delivery services for an ORG server (#7957) * Update Chromedriver Versions (#7963) Update chromedriver (cherry picked from commit 26a2f6a) * Changes for ATC 8.0.1 release. * Remove cypress node dependency * Updated changelog * Updated node dependencies * Removing minor change from PR 7957 * Removing minor change from PR 7553 --------- Co-authored-by: asf-ci-trafficcontrol <127552316+asf-ci-trafficcontrol@users.noreply.github.com> Co-authored-by: Zach Hoffman <zrhoffman@apache.org> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run TO and TP
List the delivery services assigned to an ORG server
Only those DS's should show up that are present in the deliveryservice_server table
Do the same test for other types of servers, and make sure that topologies and required_capabilities are respected
If this is a bugfix, which Traffic Control versions contained the bug?
8.0.0
PR submission checklist