TS-5056 Implement nonrecoverable error mechanism #1224
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change `Emergency()` to terminate the current process with status code UNRECOVERABLE_EXIT. Also change traffic_manager to listen for the UNRECOVERABLE_EXIT status code. If heard, then TM will not try to restart TS from that point forward. This was designed so that traffic_server could call Emergency(..) in the event of a nonrecoverable error such as a bad config file. No amount of TS rebooting will fix a bad config, so we might as well have TM wait for human intervention. Note that if traffic_cop or traffic_manager calls Emergency(), nothing totally unexpected will happen since the only visible change from this patch is the status code.
|
|
||
| va_start(ap, message_format); | ||
| ink_emergency_va(message_format, ap); | ||
| va_end(ap); |
There was a problem hiding this comment.
Hmmm. Hasn't the process already exited by this point? Maybe best to be safe, though.
|
[approve ci] |
|
I did this by hand, to squash the two commits. |
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1308/ for details. |
|
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/1202/ for details. |
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Nov 6, 2017
* asf/master: [TS-5024] Ran clang-format. Modify TSHttpTxnHookAdd to add hook only once. Modify TSHttpTxnHookAdd to add hook only once TS-4887: Fixes naming of this new API in the docs TS-5059: Port TCP Fast Open BIO to OpenSSL 1.1 get_creation_time() takes *time_t, not *long apache#1323 Restores the NULL string where appropriate Add 7.1.x to the github mirror and build triggers Doc: Updates to prevent dangling references. TS-5022: remove goto TS-5022: fix silent exit problem Fix Http2Stream *stream variable shadow reported by issue 1308. TS-5022: resource leak fix TS-5056: Implement nonrecoverable error mechanism This closes apache#1224. TS-5022: Allow multiple client cert for ATS TS-5092: ATS handling of too many concurrent streams too agressive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Emergency()to terminate the current process with statuscode UNRECOVERABLE_EXIT.
Also change traffic_manager to listen for the UNRECOVERABLE_EXIT
status code. If heard, then TM will not try to restart TS from
that point forward.
This was designed so that traffic_server could call Emergency(..)
in the event of a nonrecoverable error such as a bad config file.
No amount of TS rebooting will fix a bad config, so we might as well
have TM wait for human intervention.
Note that if traffic_cop or traffic_manager calls Emergency(),
nothing totally unexpected will happen since the only visible change
from this patch is the status code.