Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6.2.x TS-4435 and TS-5059: Fixes for building with OpenSSL 1.1 #1321

Merged
merged 4 commits into from
Feb 9, 2017
Merged

6.2.x TS-4435 and TS-5059: Fixes for building with OpenSSL 1.1 #1321

merged 4 commits into from
Feb 9, 2017

Conversation

jablko
Copy link
Contributor

@jablko jablko commented Jan 11, 2017

No description provided.

@atsci
Copy link

atsci commented Jan 11, 2017

FreeBSD build failed! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1324/ for details.

@atsci
Copy link

atsci commented Jan 11, 2017

Linux build failed! See https://ci.trafficserver.apache.org/job/Github-Linux/1218/ for details.

@atsci
Copy link

atsci commented Jan 12, 2017

Linux build failed! See https://ci.trafficserver.apache.org/job/Github-Linux/1220/ for details.

@atsci
Copy link

atsci commented Jan 12, 2017

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1326/ for details.

@atsci
Copy link

atsci commented Jan 12, 2017

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/1221/ for details.

@atsci
Copy link

atsci commented Jan 12, 2017

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1327/ for details.

@zwoop zwoop added the Backport Marked for backport for an LTS patch release label Jan 13, 2017
@zwoop zwoop added this to the 6.2.2 milestone Jan 13, 2017
@zwoop zwoop requested a review from PSUdaemon January 13, 2017 15:33
@bryancall bryancall added the TLS label Jan 13, 2017
@atsci
Copy link

atsci commented Jan 30, 2017

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1426/ for details.

@atsci
Copy link

atsci commented Jan 30, 2017

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/1319/ for details.

@PSUdaemon
Copy link
Contributor

[approve ci]

@atsci
Copy link

atsci commented Feb 9, 2017

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/freebsd-github/1500/ for details.

@atsci
Copy link

atsci commented Feb 9, 2017

Linux build successful! See https://ci.trafficserver.apache.org/job/linux-github/1393/ for details.

@atsci
Copy link

atsci commented Feb 9, 2017

clang-analyzer build failed! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/64/ for details.

@PSUdaemon
Copy link
Contributor

@jablko can you please rebase this?

shinrich and others added 4 commits February 9, 2017 14:18
@jablko
TS-4435: Changes to enable ATS to compile against openssl-1.1 beta.
cd6e82a 
(cherry picked from commit 26e1aef)
@jablko
TS-5059: SSL_set_rbio() renamed SSL_set0_rbio()
d00f000 
It was renamed before OpenSSL 1.1 was released [1][2].

[1] openssl/openssl@65e2d67
[2] https://rt.openssl.org/Ticket/Display.html?id=4572

(cherry picked from commit 1a08a61)
@jablko
TS-5059: OpenSSL 1.1 EVP_MD_CTX and HMAC_CTX
a69c609 
EVP_MD_CTX and HMAC_CTX were made opaque in OpenSSL 1.1 [1],
so allocating them on the stack is no longer supported.

Also EVP_MD_CTX_cleanup() was removed. EVP_MD_CTX_reset() should be
called instead, to reinitialise an already created structure.

[1] https://www.openssl.org/news/changelog#x4

(cherry picked from commit 92d004c)
@jablko
SSL_CTX_remove_session() and external cache
6a8dcf6 
The remove session callback is triggered when a session is removed,
so at best, calling SSL_CTX_remove_session() again is redundant.
In OpenSSL 1.1 it's recursive.

Fixes apache#1386

(cherry picked from commit cf33b5b)
@jablko
Copy link
Contributor Author

jablko commented Feb 9, 2017

@PSUdaemon Sure thing -- I rebased this.

@atsci
Copy link

atsci commented Feb 9, 2017

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/freebsd-github/1506/ for details.

@atsci
Copy link

atsci commented Feb 9, 2017

Linux build successful! See https://ci.trafficserver.apache.org/job/linux-github/1399/ for details.

@atsci
Copy link

atsci commented Feb 9, 2017

clang-analyzer build successful! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/70/ for details.

@PSUdaemon PSUdaemon self-assigned this Feb 9, 2017
@PSUdaemon PSUdaemon merged commit a858aad into apache:6.2.x Feb 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PSUdaemon PSUdaemon PSUdaemon approved these changes

Assignees

@PSUdaemon PSUdaemon

Labels
Backport Marked for backport for an LTS patch release TLS
Projects
None yet
Milestone
6.2.2
Development

Successfully merging this pull request may close these issues.
5 participants
@jablko @atsci @PSUdaemon @zwoop @bryancall