New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coverity 1021924: Missing break in switch #1780

Merged

gtenev merged 1 commit into apache:master from gtenev:coverity_1021924

May 8, 2017

Contributor

gtenev commented May 8, 2017 •

edited

Loading

Problem:
CID 1021924 (#1 of 1): Missing break in switch (MISSING_BREAK)
unterminated_case: The case for value TS_EVENT_VCONN_WRITE_READY is not terminated by a 'break' statement.

Solution:
It was intended not to have a break (not a bug), so refactored the code to make coverity happy.


          coverity 1021924: Missing break in switch

04c90b0

Problem:
  CID 1021924 (#1 of 1): Missing break in switch (MISSING_BREAK)
  unterminated_case: The case for value TS_EVENT_VCONN_WRITE_READY is not terminated by a 'break' statement.

Solution:
  It was intended not to have a break (not a bug), so refactored the code to make coverity happy.

atsci commented May 8, 2017

clang format failed! https://ci.trafficserver.apache.org/job/clang-format-github/377/

atsci commented May 8, 2017

RAT check successful! https://ci.trafficserver.apache.org/job/RAT-github/389/

atsci commented May 8, 2017

FreeBSD11 build successful! https://ci.trafficserver.apache.org/job/freebsd-github/2072/

atsci commented May 8, 2017

Intel CC build successful! https://ci.trafficserver.apache.org/job/icc-github/502/

atsci commented May 8, 2017

AU check successful! https://ci.trafficserver.apache.org/job/autest-github/373/

atsci commented May 8, 2017

Linux build successful! https://ci.trafficserver.apache.org/job/linux-github/1965/

atsci commented May 8, 2017

clang-analyzer build successful! https://ci.trafficserver.apache.org/job/clang-analyzer-github/635/

gtenev added the Coverity label

bryancall assigned gtenev

bryancall added this to the 8.0.0 milestone

Contributor Author

gtenev commented May 8, 2017

[approve ci]

atsci commented May 8, 2017

clang format successful! https://ci.trafficserver.apache.org/job/clang-format-github/378/

atsci commented May 8, 2017

RAT check successful! https://ci.trafficserver.apache.org/job/RAT-github/390/

bryancall self-requested a review

May 8, 2017 17:13

bryancall approved these changes

View reviewed changes

gtenev merged commit 98860a7 into apache:master

gtenev deleted the coverity_1021924 branch

May 8, 2017 17:15

atsci commented May 8, 2017

FreeBSD11 build successful! https://ci.trafficserver.apache.org/job/freebsd-github/2073/

atsci commented May 8, 2017

Intel CC build successful! https://ci.trafficserver.apache.org/job/icc-github/503/

atsci commented May 8, 2017

Linux build successful! https://ci.trafficserver.apache.org/job/linux-github/1966/

atsci commented May 8, 2017

AU check failed! https://ci.trafficserver.apache.org/job/autest-github/375/

atsci commented May 8, 2017

clang-analyzer build successful! https://ci.trafficserver.apache.org/job/clang-analyzer-github/636/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels