-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TS-4560: Fix C++ API shared_ptr detection. #720
Conversation
Ping @bgaff @SolidWallOfCode |
Since ink_autoconf.h is not installed, we can't use it to figure out which shared_ptr implementation to use. Further, Traffic Server might not have been built with the same toolchain that 3rd party plugins are using. Since shared_ptr is used in the C++ API headers, both Traffic Server and the plugins need to agree on which implementation to use. The best (but not perfect) solution is to hardcode it into the header file during the Traffic Server build. This means that both parties are consistent and any remaining problems could be attributed to C++ standard library compatibility.
FreeBSD build failed! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/295/ for details. |
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/187/ for details. |
Not sure why the FreeBSD build failed, trying again. [approve ci] |
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/296/ for details. |
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/188/ for details. |
I'm not sure what you mean by this. This patch is removing |
Sorry I was referring specifically to the config ( the txn config set enums ) but I think this solves that too. Please land this, thanks for doing it! |
…#8776) (apache#720) * Fix incrementation and logging of server connection attempts for transaction. * Changes to PR 8776 required by code review. Co-authored-by: Walt Karas <wkaras@yahooinc.com> (cherry picked from commit eb250b5) Conflicts: proxy/http/HttpSM.cc proxy/http/HttpTransact.cc proxy/http/HttpTransact.h
Since ink_autoconf.h is not installed, we can't use it to figure
out which shared_ptr implementation to use. Further, Traffic Server
might not have been built with the same toolchain that 3rd party
plugins are using.
Since shared_ptr is used in the C++ API headers, both Traffic Server
and the plugins need to agree on which implementation to use. The
best (but not perfect) solution is to hardcode it into the header
file during the Traffic Server build. This means that both parties
are consistent and any remaining problems could be attributed to
C++ standard library compatibility.