TS-4518 Add the basic APIs and code for UUIDs #736
Conversation
|
Linux build failed! See https://ci.trafficserver.apache.org/job/Github-Linux/227/ for details. |
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/333/ for details. |
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/334/ for details. |
|
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/228/ for details. |
| TS_UUID_V5, | ||
| } TSUuidVersion; | ||
|
|
||
| #define TSUuidStringLen 36 |
There was a problem hiding this comment.
This should be TS_UUID_STRING_LEN to be consistent with TS_MAX_USER_NAME_LEN, which is the only precedent I could find :)
|
Looks pretty good to me. I just had some minor comments, mainly style suggestions. 👍 |
|
@jpeach Agree with all the review comments, will address asap and post an update tomorrow (monday). Note that this also changes TSDestroy() to have no failure scenario, so for correctness I'm changing its prototype to This is inline with other Destroy() functions that can not fail. |
zwoop
force-pushed
the
TS-4518
branch
3 times, most recently
from
86548fa
to
71b4681
Compare
|
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/242/ for details. |
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/348/ for details. |
| This example uses :func:`TSDebugSpecific` to log a message when a specific | ||
| debugging flag is enabled:: | ||
|
|
||
| #include <ts/apidefs.h> |
|
Looks good 👍 |
zwoop
force-pushed
the
TS-4518
branch
2 times, most recently
from
35e35ec
to
05e509b
Compare
|
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/244/ for details. |
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/350/ for details. |
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/351/ for details. |
|
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/245/ for details. |
Revert "Change the default value for request_line_max_size to 32KB (#…
This implements the UUID stuff, as well as exposing the TXN ID in a TS API.