TS-4542: ASAN error with HTTP/2 priority #751
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/359/ for details. |
|
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/253/ for details. |
|
This seems good, +1. One comment, as discussed on the IRC: It seems unfortunate that we have two state variables (closed=true, and the _state= HTTP2_STREAM_STATE_CLOSED for H2) indicating the same state. It seems that we ended up with this bug because we set the closed=true, but forgot to update the _state. At a minimum, maybe we should add some strategic ink_assert() in places where these two can get obviously out of sync? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.