[Relax] Normalize use of void-type variable to inline R.tuple() #16658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lunderberg
force-pushed
the
relax_normalize_use_of_void_variable
branch
from
502f828
to
edddfc3
Compare
slyubomirsky
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
This will be good for avoiding the tricky situation that arises with #16641, mainly where it can be a problem to omit the binding of a unit-type variable if the var is used later. I think it's pretty harmless to simply inline all unit values.
This is a follow-up commit to apache#16641. While parsing of relax expressions without a variable binding could be implemented at that point (e.g. `R.assert_op(condition)` instead of `dummy_var = R.assert_op(condition)`), the corresponding printing changes could not. This was because a variable that satisfies `relax::HasVoidStructInfo(var)` could still be used later in the function, and removing its binding would result in use of an undefined variable. This commit normalizes use of void-type variables to an in-line `R.tuple()`. This simplifies the relax function, and also allows the binding of void-type variables to be hidden.
Lunderberg
force-pushed
the
relax_normalize_use_of_void_variable
branch
from
edddfc3
to
844f06c
Compare
Lunderberg
changed the title
Agreed, and it matches our existing behavior for things like |
thaisacs
pushed a commit
to thaisacs/tvm
that referenced
this pull request
Apr 3, 2024
…he#16658) * [Relax] Normalize use of void-type variable to inline R.tuple() This is a follow-up commit to apache#16641. While parsing of relax expressions without a variable binding could be implemented at that point (e.g. `R.assert_op(condition)` instead of `dummy_var = R.assert_op(condition)`), the corresponding printing changes could not. This was because a variable that satisfies `relax::HasVoidStructInfo(var)` could still be used later in the function, and removing its binding would result in use of an undefined variable. This commit normalizes use of void-type variables to an in-line `R.tuple()`. This simplifies the relax function, and also allows the binding of void-type variables to be hidden. * Fix breakage in unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up commit to #16641. While parsing of relax expressions without a variable binding could be implemented at that point (e.g.
R.assert_op(condition)instead ofdummy_var = R.assert_op(condition)), the corresponding printing changes could not. This was because a variable that satisfiesrelax::HasVoidStructInfo(var)could still be used later in the function, and removing its binding would result in use of an undefined variable.This commit normalizes use of void-type variables to an in-line
R.tuple(). This simplifies the relax function, and also allows the binding of void-type variables to be hidden.