Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should '=' be '==' ? #108

Closed
sebbASF opened this issue Nov 23, 2020 · 3 comments
Closed

Should '=' be '==' ? #108

sebbASF opened this issue Nov 23, 2020 · 3 comments

Comments

@sebbASF
Copy link
Contributor

sebbASF commented Nov 23, 2020

whimsy/lib/whimsy/asf/rack.rb

Line 153 in 2ad1a79

if ary = env['rack.after_reply']

@rubys The operator here looks odd.
Is it supposed to be equality rather than assignment?
@rubys
Copy link
Member

rubys commented Nov 23, 2020

This is supposed to be equality. Follow the link in the comment on line 150 to see the original code. Perhaps adding parens or splitting in two lines will placate whatever linter you are using?

@sebbASF
Copy link
Contributor Author

sebbASF commented Nov 23, 2020

Do you mean assignment?

@rubys
Copy link
Member

rubys commented Nov 23, 2020

Yes, I meant the assignment operator.

@asfgit asfgit closed this as completed in 28f39b4 Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rubys @sebbASF