Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename opt_name to name #274

Closed
PythonFZ opened this issue May 6, 2024 · 2 comments
Closed

Rename opt_name to name #274

PythonFZ opened this issue May 6, 2024 · 2 comments

Comments

@PythonFZ
Copy link
Contributor

PythonFZ commented May 6, 2024

opt_name: str = "adam"
emb_lr: NonNegativeFloat = 0.02
nn_lr: NonNegativeFloat = 0.03
scale_lr: NonNegativeFloat = 0.001
shift_lr: NonNegativeFloat = 0.05
zbl_lr: NonNegativeFloat = 0.001
transition_begin: int = 0
opt_kwargs: dict = {}
sam_rho: NonNegativeFloat = 0.0

I suggest going from:

optimizer:
  opt_name: adam
  opt_kwargs: ...
  emb_lr: 0.01
  nn_lr: 0.005
  scale_lr: 0.001
  shift_lr: 0.05
  zbl_lr: 0.001

to

optimizer:
  name: adam
  kwargs: ...
  emb_lr: 0.01
  nn_lr: 0.005
  scale_lr: 0.001
  shift_lr: 0.05
  zbl_lr: 0.001

to remove redundant information

@M-R-Schaefer
Copy link
Contributor

good point!

@M-R-Schaefer
Copy link
Contributor

fixed in v0.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants