Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write stream files with a selection of the reflections from another stream file #5

Closed
fredericpoitevin opened this issue Jan 20, 2022 · 1 comment · Fixed by #7
Closed

Comments

@fredericpoitevin
Copy link
Collaborator

(I know you already are working on it Ariana, just thought I'd put this here for my own records)

We'd like to be able to:

  • read a given stream file
  • do some analysis on the reflections
  • select reflections based on this analysis
  • write a stream file with only the reflections selected
@apeck12
Copy link
Owner

apeck12 commented Jan 21, 2022

Thanks for creating an issue for this, Fred! Much easier to keep track of to-do's this way.

Note to self on this topic: it may be useful to additionally keep track of the chunk number in the stream_data self variable to simplify generating a new stream file with select reflections. This way, if a chunk doesn't have legitimate reflections, it can be skipped altogether.

Second note to self on this topic: the stream_data variable is a bit unwieldy, so it may be worth adding one-line functions to the StreamInterface class that returns the correct column of stream_data when called.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants