Fix the URL generated when no arguments is passed to .logs

[AMR-KELEG]

Fixes #474
Remove the excess .log added to the end of the URL when .logs is
used with no arguments.

[AMR-KELEG]

I am sure that this tweak will fix the bug but I wasn't able to test it locally.
Do you have any recommendations on how to edit the default.py file such that I can test the bot?

[sushain97]

Hmm, it's been a while since I've run this bot so I'm not sure. Are you getting an error when running it?

Also, I suggest just adding a test that verifies this behavior! That should be sufficient.

[AMR-KELEG]

I am not sure what should happen when I run the bot locally.
I believe that the bot tries somehow to connect to the IRC channel.

My question is how to update values like host, channels in the default.py file?

nick = 'phenny'
host = ''
port = 6667
ssl = False
# This requires password to be set
sasl = False
ipv6 = False
channels = ['#example', '#test']

[sushain97]

Ah, use a test channel like #amr-keleg-phenny-test. Host is probably the freenode IRC url. The others shouldn't need to be set.

[sushain97]

Please use single quotes to match the rest of the file. Also, just go ahead and inline this since there's only one check.

[AMR-KELEG]

Actually, the file has mixed single and double quotes.

[sushain97]

Argh. Okay, then this is fine. If you'd like, switch them all to be consistent.

[AMR-KELEG]

Yes, I would like to do so.
Does Apertium has some sort of coding conventions?
I also prefer single quotes for strings

[sushain97]

For this repo, no. In apertium-streamparser, apertium-init and apertium-apy, we stick to single quotes. So, that works for me.

[AMR-KELEG]

I prefer opening a new issue for the mixed single and double quotes.
I also think we should check the rest of the repo's files.

[sushain97]

There are too many stylistic issues/inconsistencies for a single issue and given that this repo is a fork, I'd like to stay away from sweeping changes, It's fine for this file since this module doesn't exist in upstream.

[sushain97]

Do you mind providing a transcript of a chat log while you were testing? Then this should be mergeable. Thanks!

[AMR-KELEG]

Do you mind providing a transcript of a chat log while you were testing? Then this should be mergeable. Thanks!

Can I just copy the messages from the testing channel and paste them as a comment here?

[sushain97]

Yeah, that's what I mean by transcript.

[AMR-KELEG]

Do you mind providing a transcript of a chat log while you were testing? Then this should be mergeable. Thanks!

[00:12] == AMR-KELEG [***] has joined #amr-keleg-phenny-test
[00:12] == mode/#amr-keleg-phenny-test [+ns] by herbert.freenode.net
[00:12] == phenny [~phenny@***] has joined #amr-keleg-phenny-test
[00:12] <@AMR-KELEG> .log
[00:12] <phenny> Log at https://tinodidriksen.com/pisg/freenode/logs/%23amr-keleg-phenny-test/

[sushain97]

Good work!

[AMR-KELEG]

Thanks @sushain97.
I would like to know what will happen now.
Is there a server on which phenny is running?
And if this is the case, Will we need to restart the bot so that the changes will get applied?

[sushain97]

@jonorthwash usually takes care of restarting it.

[jonorthwash]

I pulled and restarted, but it looks like I only got the following updates:

Merge made by the 'recursive' strategy.
 modules/apertium_wiki.py           | 2 +-
 modules/test/test_apertium_wiki.py | 7 +++++++
 2 files changed, 8 insertions(+), 1 deletion(-)

[jonorthwash]

Oh, interesting, those look like what the PR contained. I'd guessed the logs had their own module.

[AMR-KELEG]

@jonorthwash Yes, actually the solution required a simple tweak.
Thanks.