Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent toggleButton from getting called on input enter #23

Merged
merged 1 commit into from
Aug 29, 2018

Conversation

tksumanth1994
Copy link
Contributor

Description

When this component is placed inside a <form> component, on pressing enter instead of submitting the form, it click on the togglePassword button. Adding type="button" fixes that issue.

Fix or Feature?

Fix

Environment

  • OS: MacOS (But should work the same in all)
  • NPM Version: 6.2.0

@apertureless
Copy link
Owner

Thanks for this!

@apertureless apertureless merged commit 5cf25a2 into apertureless:develop Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants