Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo: "Udpate" should be "Update" #263

Closed
william-powell opened this issue Jan 17, 2020 · 0 comments
Closed

Typo: "Udpate" should be "Update" #263

william-powell opened this issue Jan 17, 2020 · 0 comments

Comments

@william-powell
Copy link

fflib-apex-common/fflib/src/classes/fflib_SObjectDomainTest.cls

Line 130 in 8b2a6f8

System.assertEquals('Permission to udpate an Opportunity denied.', e.getMessage());

ImJohnMDaniel added a commit that referenced this issue Jan 22, 2020
@ImJohnMDaniel
Merge pull request #265 from patronmanager/263-typo-in-test-assertion
e1d19f9 
Fixes #263 - test assertion using string with typo in it
jsardello pushed a commit to lampo/salesforce-apex-common that referenced this issue Jul 10, 2020
@dscasper @TheRickParker
@tahsinz @dbtavernerffdc @cgjerow @kjonescertinia @stefanopallicca-imagicle @wimvelzeboer @ImJohnMDaniel @afawcett @daveespo @TrangOul @JAertgeerts
Update form fork 07202020 (#6)
e85828a 
* Added new overload to registerRelationship to allow reference by External Id. The changes cannot be covered by a Unit Test due to lack of such references on standard sObjects. Changes were tested manually in a scratch org in execute anonymous using custom objects.

* Default Sorting considering invalid field and shield

Financial Force library (FFLIB) by default sorts record based on CreatedDate. Some object (ie. account share) might not have the field and hence will through error.  This change checks the field encryption (taken from @wimvelzeboer ) and if the object does not have created date field, assigns Id as default sorting field.

* Cleaned up the code based on pull request feedback.

* Update fflib_SObjectSelector.cls

Fixing the comment-blocking indenting issues (caused by IDE)

* Update fflib_SObjectSelector.cls

Updated the access modifiers from protected to private.

* correct spelling of word updates within comment and exception message

* Adding new method to mocks

* Rebrand as FFLib Apex Common & correct copyright notices to match git history

* ChildRelationship -> Schema.ChildRelationship

* upgrade api version

* Allow mocking for getChangedRecords

The hardcoded reference to the readonly Trigger.oldMap is replace so that it can be mocked in unit-tests

* Add mocking for getChangedRecords via Test.Database

* Add empty recycle bin to UnitOfWork

* Update README.md

* Add fluent design to the class constructor

With this change a selector can be configured via AccountsSelector selector = new AccountsSelector().enforceFLS();

* Add missing return statement for fluent design to the class constructor

With this change a selector can be configured via AccountsSelector selector = new AccountsSelector().enforceFLS();

* Add the option to extend the Application class.

This will allow an extension that could combine the force-di repo with the fflib-apex-commons.

* Updated to 47.0

* Fix for failing unit test by adding required methods to implementations

* 186 - consistent license version across source

* apex-enterprise-patterns#199 - mark fflib_SObjectSelector methods as virtual that do actual SOQL -- permits override in a 'without sharing' subclass

* Fixes apex-enterprise-patterns#263 - test assertion using string with typo in it (caused by apex-enterprise-patterns#234)

* Update fflib_SObjectUnitOfWork.cls

typo

* Fixes apex-enterprise-patterns#259

Changes made:
* Migrated all code to Salesforce DX Source format

* Update to document this change

* Update README.md

Updated Deploy button to not hard code the repo name. This means branch deploys work.

* Updating API version of Apex Commons (#1)

* Updating API version of Apex Commons

Updating API version of Apex Commons

* Adding Code Owners

Adding Code Owners

* Update from apex enterprise patterns master of fflib_Apex_Common (#3)

* Added new overload to registerRelationship to allow reference by External Id. The changes cannot be covered by a Unit Test due to lack of such references on standard sObjects. Changes were tested manually in a scratch org in execute anonymous using custom objects.

* Default Sorting considering invalid field and shield

Financial Force library (FFLIB) by default sorts record based on CreatedDate. Some object (ie. account share) might not have the field and hence will through error.  This change checks the field encryption (taken from @wimvelzeboer ) and if the object does not have created date field, assigns Id as default sorting field.

* Cleaned up the code based on pull request feedback.

* Update fflib_SObjectSelector.cls

Fixing the comment-blocking indenting issues (caused by IDE)

* Update fflib_SObjectSelector.cls

Updated the access modifiers from protected to private.

* Adding new method to mocks

* Rebrand as FFLib Apex Common & correct copyright notices to match git history

* upgrade api version

* Allow mocking for getChangedRecords

The hardcoded reference to the readonly Trigger.oldMap is replace so that it can be mocked in unit-tests

* Add mocking for getChangedRecords via Test.Database

* Update README.md

* Add fluent design to the class constructor

With this change a selector can be configured via AccountsSelector selector = new AccountsSelector().enforceFLS();

* Add missing return statement for fluent design to the class constructor

With this change a selector can be configured via AccountsSelector selector = new AccountsSelector().enforceFLS();

* Add the option to extend the Application class.

This will allow an extension that could combine the force-di repo with the fflib-apex-commons.

* Updated to 47.0

Co-authored-by: Rick Parker <45234060+TheRickParker@users.noreply.github.com>
Co-authored-by: Tahsin Zulkarnine <tahsinz@gmail.com>
Co-authored-by: dbtavernerffdc <dbtaverner@financialforce.com>
Co-authored-by: kjonesffdc <31822118+kjonesffdc@users.noreply.github.com>
Co-authored-by: Jan Aertgeerts <jan@janaertgeerts.be>
Co-authored-by: William Velzeboer <wgj.velzeboer@gmail.com>
Co-authored-by: John M. Daniel <ImJohnMDaniel@users.noreply.github.com>
Co-authored-by: Andrew Fawcett <andy@andyinthecloud.com>

* Add idea to git ignore

Co-authored-by: Rick Parker <rick.lee.parker@gmail.com>
Co-authored-by: Tahsin Zulkarnine <tahsinz@gmail.com>
Co-authored-by: dbtavernerffdc <dbtaverner@financialforce.com>
Co-authored-by: Connor Jerow <cgjerow@gmail.com>
Co-authored-by: Kevin Jones <kjones@financialforce.com>
Co-authored-by: Stefano Pallicca <stefano.pallicca@imagicle.com>
Co-authored-by: Jan Aertgeerts <jaertgee@its.jnj.com>
Co-authored-by: William Velzeboer <wgj.velzeboer@gmail.com>
Co-authored-by: William Velzeboer <wvelzebo@its.jnj.com>
Co-authored-by: Wim Velzeboer <wimvelzeboer@outlook.com>
Co-authored-by: John M. Daniel <ImJohnMDaniel@users.noreply.github.com>
Co-authored-by: Andrew Fawcett <andy@andyinthecloud.com>
Co-authored-by: David Esposito <dave@patrontechnology.com>
Co-authored-by: David Esposito <233309+daveespo@users.noreply.github.com>
Co-authored-by: Marek Madejski <marekmadejski@yandex.com>
Co-authored-by: John M. Daniel <imjohnmdaniel@ce-v.com>
Co-authored-by: Rick Parker <45234060+TheRickParker@users.noreply.github.com>
Co-authored-by: kjonesffdc <31822118+kjonesffdc@users.noreply.github.com>
Co-authored-by: Jan Aertgeerts <jan@janaertgeerts.be>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@william-powell