correct spelling of word updates within comment and exception message #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foxysolutions
approved these changes
Dec 26, 2019
wimvelzeboer
approved these changes
Jan 7, 2020
daveespo
approved these changes
Jan 7, 2020
jsardello
pushed a commit
to lampo/salesforce-apex-common
that referenced
this pull request
Jul 10, 2020
* Added new overload to registerRelationship to allow reference by External Id. The changes cannot be covered by a Unit Test due to lack of such references on standard sObjects. Changes were tested manually in a scratch org in execute anonymous using custom objects. * Default Sorting considering invalid field and shield Financial Force library (FFLIB) by default sorts record based on CreatedDate. Some object (ie. account share) might not have the field and hence will through error. This change checks the field encryption (taken from @wimvelzeboer ) and if the object does not have created date field, assigns Id as default sorting field. * Cleaned up the code based on pull request feedback. * Update fflib_SObjectSelector.cls Fixing the comment-blocking indenting issues (caused by IDE) * Update fflib_SObjectSelector.cls Updated the access modifiers from protected to private. * correct spelling of word updates within comment and exception message * Adding new method to mocks * Rebrand as FFLib Apex Common & correct copyright notices to match git history * ChildRelationship -> Schema.ChildRelationship * upgrade api version * Allow mocking for getChangedRecords The hardcoded reference to the readonly Trigger.oldMap is replace so that it can be mocked in unit-tests * Add mocking for getChangedRecords via Test.Database * Add empty recycle bin to UnitOfWork * Update README.md * Add fluent design to the class constructor With this change a selector can be configured via AccountsSelector selector = new AccountsSelector().enforceFLS(); * Add missing return statement for fluent design to the class constructor With this change a selector can be configured via AccountsSelector selector = new AccountsSelector().enforceFLS(); * Add the option to extend the Application class. This will allow an extension that could combine the force-di repo with the fflib-apex-commons. * Updated to 47.0 * Fix for failing unit test by adding required methods to implementations * 186 - consistent license version across source * apex-enterprise-patterns#199 - mark fflib_SObjectSelector methods as virtual that do actual SOQL -- permits override in a 'without sharing' subclass * Fixes apex-enterprise-patterns#263 - test assertion using string with typo in it (caused by apex-enterprise-patterns#234) * Update fflib_SObjectUnitOfWork.cls typo * Fixes apex-enterprise-patterns#259 Changes made: * Migrated all code to Salesforce DX Source format * Update to document this change * Update README.md Updated Deploy button to not hard code the repo name. This means branch deploys work. * Updating API version of Apex Commons (#1) * Updating API version of Apex Commons Updating API version of Apex Commons * Adding Code Owners Adding Code Owners * Update from apex enterprise patterns master of fflib_Apex_Common (#3) * Added new overload to registerRelationship to allow reference by External Id. The changes cannot be covered by a Unit Test due to lack of such references on standard sObjects. Changes were tested manually in a scratch org in execute anonymous using custom objects. * Default Sorting considering invalid field and shield Financial Force library (FFLIB) by default sorts record based on CreatedDate. Some object (ie. account share) might not have the field and hence will through error. This change checks the field encryption (taken from @wimvelzeboer ) and if the object does not have created date field, assigns Id as default sorting field. * Cleaned up the code based on pull request feedback. * Update fflib_SObjectSelector.cls Fixing the comment-blocking indenting issues (caused by IDE) * Update fflib_SObjectSelector.cls Updated the access modifiers from protected to private. * Adding new method to mocks * Rebrand as FFLib Apex Common & correct copyright notices to match git history * upgrade api version * Allow mocking for getChangedRecords The hardcoded reference to the readonly Trigger.oldMap is replace so that it can be mocked in unit-tests * Add mocking for getChangedRecords via Test.Database * Update README.md * Add fluent design to the class constructor With this change a selector can be configured via AccountsSelector selector = new AccountsSelector().enforceFLS(); * Add missing return statement for fluent design to the class constructor With this change a selector can be configured via AccountsSelector selector = new AccountsSelector().enforceFLS(); * Add the option to extend the Application class. This will allow an extension that could combine the force-di repo with the fflib-apex-commons. * Updated to 47.0 Co-authored-by: Rick Parker <45234060+TheRickParker@users.noreply.github.com> Co-authored-by: Tahsin Zulkarnine <tahsinz@gmail.com> Co-authored-by: dbtavernerffdc <dbtaverner@financialforce.com> Co-authored-by: kjonesffdc <31822118+kjonesffdc@users.noreply.github.com> Co-authored-by: Jan Aertgeerts <jan@janaertgeerts.be> Co-authored-by: William Velzeboer <wgj.velzeboer@gmail.com> Co-authored-by: John M. Daniel <ImJohnMDaniel@users.noreply.github.com> Co-authored-by: Andrew Fawcett <andy@andyinthecloud.com> * Add idea to git ignore Co-authored-by: Rick Parker <rick.lee.parker@gmail.com> Co-authored-by: Tahsin Zulkarnine <tahsinz@gmail.com> Co-authored-by: dbtavernerffdc <dbtaverner@financialforce.com> Co-authored-by: Connor Jerow <cgjerow@gmail.com> Co-authored-by: Kevin Jones <kjones@financialforce.com> Co-authored-by: Stefano Pallicca <stefano.pallicca@imagicle.com> Co-authored-by: Jan Aertgeerts <jaertgee@its.jnj.com> Co-authored-by: William Velzeboer <wgj.velzeboer@gmail.com> Co-authored-by: William Velzeboer <wvelzebo@its.jnj.com> Co-authored-by: Wim Velzeboer <wimvelzeboer@outlook.com> Co-authored-by: John M. Daniel <ImJohnMDaniel@users.noreply.github.com> Co-authored-by: Andrew Fawcett <andy@andyinthecloud.com> Co-authored-by: David Esposito <dave@patrontechnology.com> Co-authored-by: David Esposito <233309+daveespo@users.noreply.github.com> Co-authored-by: Marek Madejski <marekmadejski@yandex.com> Co-authored-by: John M. Daniel <imjohnmdaniel@ce-v.com> Co-authored-by: Rick Parker <45234060+TheRickParker@users.noreply.github.com> Co-authored-by: kjonesffdc <31822118+kjonesffdc@users.noreply.github.com> Co-authored-by: Jan Aertgeerts <jan@janaertgeerts.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.