This repository has been archived by the owner on Oct 6, 2020. It is now read-only.
Update form fork 07202020 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rnal Id. The changes cannot be covered by a Unit Test due to lack of such references on standard sObjects. Changes were tested manually in a scratch org in execute anonymous using custom objects.
Financial Force library (FFLIB) by default sorts record based on CreatedDate. Some object (ie. account share) might not have the field and hence will through error. This change checks the field encryption (taken from @wimvelzeboer ) and if the object does not have created date field, assigns Id as default sorting field.
Fixing the comment-blocking indenting issues (caused by IDE)
Updated the access modifiers from protected to private.
Default Sorting considering invalid field and shield
…ster Added new overload to registerRelationship supporting External ID refs
…nd-and-Copyright-Corrections Rebrand as FFLib Apex Common & correct copyright notices
merge fflib-apex-common back to master of fork
The hardcoded reference to the readonly Trigger.oldMap is replace so that it can be mocked in unit-tests
With this change a selector can be configured via AccountsSelector selector = new AccountsSelector().enforceFLS();
With this change a selector can be configured via AccountsSelector selector = new AccountsSelector().enforceFLS();
This will allow an extension that could combine the force-di repo with the fflib-apex-commons.
…ture/VirtualApplication Feature/virtual application
…ure/api-version upgrade api version
…ture/FluentSelectorConstructor Feature/fluent selector constructor
…ture/MockingDomaingetChangesRecords feature/mocking domain getChangedRecords
…virtual that do actual SOQL -- permits override in a 'without sharing' subclass
correct spelling of word updates within comment and exception message
… typo in it (caused by apex-enterprise-patterns#234)
…3-typo-in-test-assertion Fixes apex-enterprise-patterns#263 - test assertion using string with typo in it
…ture/registerEmptyRecycleBin Add register empty recycle bin to UnitOfWork
ChildRelationship -> Schema.ChildRelationship
…ure/license-version apex-enterprise-patterns#186 - consistent license version across source
…9-virtualize-selector-methods apex-enterprise-patterns#199 - mark fflib_SObjectSelector methods as virtual
Update fflib_SObjectUnitOfWork.cls
Changes made: * Migrated all code to Salesforce DX Source format
Updated Deploy button to not hard code the repo name. This means branch deploys work.
…patterns/feature/migration-to-sfdx-format Fixes apex-enterprise-patterns#259 -- Migration of code to SFDX Source format
* Updating API version of Apex Commons Updating API version of Apex Commons * Adding Code Owners Adding Code Owners
* Added new overload to registerRelationship to allow reference by External Id. The changes cannot be covered by a Unit Test due to lack of such references on standard sObjects. Changes were tested manually in a scratch org in execute anonymous using custom objects. * Default Sorting considering invalid field and shield Financial Force library (FFLIB) by default sorts record based on CreatedDate. Some object (ie. account share) might not have the field and hence will through error. This change checks the field encryption (taken from @wimvelzeboer ) and if the object does not have created date field, assigns Id as default sorting field. * Cleaned up the code based on pull request feedback. * Update fflib_SObjectSelector.cls Fixing the comment-blocking indenting issues (caused by IDE) * Update fflib_SObjectSelector.cls Updated the access modifiers from protected to private. * Adding new method to mocks * Rebrand as FFLib Apex Common & correct copyright notices to match git history * upgrade api version * Allow mocking for getChangedRecords The hardcoded reference to the readonly Trigger.oldMap is replace so that it can be mocked in unit-tests * Add mocking for getChangedRecords via Test.Database * Update README.md * Add fluent design to the class constructor With this change a selector can be configured via AccountsSelector selector = new AccountsSelector().enforceFLS(); * Add missing return statement for fluent design to the class constructor With this change a selector can be configured via AccountsSelector selector = new AccountsSelector().enforceFLS(); * Add the option to extend the Application class. This will allow an extension that could combine the force-di repo with the fflib-apex-commons. * Updated to 47.0 Co-authored-by: Rick Parker <45234060+TheRickParker@users.noreply.github.com> Co-authored-by: Tahsin Zulkarnine <tahsinz@gmail.com> Co-authored-by: dbtavernerffdc <dbtaverner@financialforce.com> Co-authored-by: kjonesffdc <31822118+kjonesffdc@users.noreply.github.com> Co-authored-by: Jan Aertgeerts <jan@janaertgeerts.be> Co-authored-by: William Velzeboer <wgj.velzeboer@gmail.com> Co-authored-by: John M. Daniel <ImJohnMDaniel@users.noreply.github.com> Co-authored-by: Andrew Fawcett <andy@andyinthecloud.com>
# Conflicts: # .gitignore # README.md # fflib/src/classes/fflib_ISObjectDomain.cls # fflib/src/classes/fflib_ISObjectSelector.cls # fflib/src/package.xml # sfdx-source/apex-common/main/classes/fflib_ISObjectUnitOfWork.cls # sfdx-source/apex-common/main/classes/fflib_QueryFactory.cls # sfdx-source/apex-common/test/classes/fflib_ApplicationTest.cls # sfdx-source/apex-common/test/classes/fflib_QueryFactoryTest.cls
lucascummins
approved these changes
Jul 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this one Works