relay: disable keep alive conns, they interact poorly with suspension #365
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I expect the
DisableKeepAlives
change to eliminate the EOF / conn reset errors. Without those errors we would never have found the re-read request body error, which is explicitly addressed by the newGetBody
code.A few justifications for the other changes:
Continue
responses.GetBody
code, this is already handled by http.NewRequest