Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logo URL in readme.md #1

Closed
mikaelkaron opened this issue Mar 18, 2019 · 1 comment
Closed

Fix logo URL in readme.md #1

mikaelkaron opened this issue Mar 18, 2019 · 1 comment
Assignees
@junedchhipa

Comments

@mikaelkaron
Copy link
Collaborator

At the moment the stencil-apexcharts logo is using a relative path that breaks on npmjs.com.

Looking at the other *-apexcharts logos they are loaded from https://apexcharts.com/media/*-apexcharts.png or similar and it would be nice if this was the case for stencil-apexcharts as well.
@mikaelkaron
Copy link
Collaborator Author

Another option would be to set it to the GitHub URL (https://github.com/apexcharts/stencil-apexcharts/raw/master/assets/stencil-apexcharts.png) to keep the repo "atomic"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@junedchhipa junedchhipa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikaelkaron @junedchhipa