fix: don't ignore login data set via CLI params (regression from #316) #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanpoulain
changed the title
alanpoulain
approved these changes
Apr 14, 2022
|
LGTM, you need to fix the CS too. |
…platform#316) In attempting to fix an empty `options` object overshadowing the options set by the user via CLI, api-platform#316 mistakenly adjusted `options.username`, `options.password` and `options.bearer` to be attributes of the newly introduced `parserOptions`. They should, however, still refer to the `options` object that holds all the information previously set via CLI arguments. I also added two comments to make the difference between the two sets of options more clear.
|
@alanpoulain What do you mean by "CS"? I just addressed the one linter error I missed (in a squashed commit, therefore the force push). |
|
CS: Code Style (the linter error). |
|
oh, gotcha. You're welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In attempting to fix an empty
optionsobject overshadowing the options set by the user via CLI, #316 mistakenly adjustedoptions.username,options.passwordandoptions.bearerto be attributes of the newly introducedparserOptions. They should, however, still refer to theoptionsobject that holds all the information previously set via CLI arguments.I also added two comments to make the difference between the two sets of options more clear.