fix: don't ignore login data set via CLI params (regression from #316) #325
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In attempting to fix an empty
options
object overshadowing the options set by the user via CLI, #316 mistakenly adjustedoptions.username
,options.password
andoptions.bearer
to be attributes of the newly introducedparserOptions
. They should, however, still refer to theoptions
object that holds all the information previously set via CLI arguments.I also added two comments to make the difference between the two sets of options more clear.