Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't ignore login data set via CLI params (regression from #316) #325

Merged
merged 1 commit into from
Apr 14, 2022
Merged

fix: don't ignore login data set via CLI params (regression from #316) #325

merged 1 commit into from
Apr 14, 2022

Commits on Apr 14, 2022

  1. fix: Don't ignore login data set via CLI params (regression from api-… 

    …platform#316)

In attempting to fix an empty `options` object overshadowing the options set by the user via CLI, api-platform#316 mistakenly adjusted `options.username`, `options.password` and `options.bearer` to be attributes of the newly introduced `parserOptions`. They should, however, still refer to the `options` object that holds all the information previously set via CLI arguments.
I also added two comments to make the difference between the two sets of options more clear.
    @Sirs0ri
    Sirs0ri committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    7db1671 View commit details
    Browse the repository at this point in the history