hotfix: add an exception for item per page equal 0 #1141
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Simperfit
commented
May 26, 2017
Simperfit
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #1118 |
| License | MIT |
Make filters's ids defaulting to the service name
Add configuration option to define custom loader paths
Use the stable version of PHP CS Fixer 2
Make swagger UI compatible in a CSP environment
…-comparison Add nulls comparison to OrderFilter
…fier Move normalizeIdentifiers method to a new Util class IdentifierManager
…test minor: add missing test for contextBuilder
Move properties in IdentifierManagerTrait and fix CS.
Also resolves conflicts with existing subresources on a property having the same name
Fix route name resolving with subresources
Fix master tests
…d-filter Manage embedded fields for API Platform Filter
Builtin cache invalidation system aka make API Platform fast as hell
…sues Fix small behat test issues
|
What if I send negative number? :) |
Simperfit
force-pushed
the
hotfix/add-an-exception-for-item-per-page
branch
from
6ac81e5
to
83a599a
Compare
soyuka
approved these changes
May 27, 2017
Simperfit
force-pushed
the
hotfix/add-an-exception-for-item-per-page
branch
from
3692352
to
a9dc54a
Compare
|
@soyuka done :) |
dunglas
approved these changes
May 29, 2017
meyerbaptiste
approved these changes
May 29, 2017
|
bug fix no? Shouldn't this target 2.0? |
Simperfit
force-pushed
the
hotfix/add-an-exception-for-item-per-page
branch
from
a9dc54a
to
8eb4e65
Compare
|
@Simperfit you need to rebase ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.