Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert HTTP method to uppercase #2734

Merged
merged 1 commit into from
Apr 15, 2019
Merged

Convert HTTP method to uppercase #2734

merged 1 commit into from
Apr 15, 2019

Conversation

teohhanhui
Copy link
Contributor

@teohhanhui teohhanhui commented Apr 15, 2019 •
edited
Loading

Q A
Bug fix? no, but prevent bug in client application
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A

#2712 targeted master. Cherry-picked for 2.4 instead.

@teohhanhui teohhanhui mentioned this pull request Apr 15, 2019
Closed
@soyuka
Copy link
Member

soyuka commented Apr 15, 2019

we could add a test though

@alanpoulain
Copy link
Member

Do you know you can edit the initial PR?

@teohhanhui
Copy link
Contributor Author

@alanpoulain #2712 (comment) 😛

@teohhanhui teohhanhui merged commit 7e50ddd into 2.4 Apr 15, 2019
@teohhanhui teohhanhui deleted the ensure-verb-is-uppercase branch April 15, 2019 19:23
@teohhanhui
Copy link
Contributor Author

Thanks @lyrixx! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soyuka soyuka soyuka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@teohhanhui @soyuka @alanpoulain @lyrixx