Convert HTTP method to uppercase #2712
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lyrixx
commented
Apr 7, 2019
•
lyrixx
commented
| Q | A |
|---|---|
| Bug fix? | no, but prevent bug in client application |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
…ion-language Use framework expression language service instead of custom one
…types [GraphQL] Custom types
GraphQL: Prevent an error when the type factory is null
merging 2.4 into master nothing to see here
Add tests for the SoMany collection Uses the PropertyAccessor service and don't break the BC Allow to use multiple fields Fix cs Improve cursor-based pagination tests
Enable the pagination via cursor (no page-based pagination)
Merge 2.4 onto master
* Better support for graphql pagination Add support for graphql before, last, startcursor * Allow limit 0 for MongoDB * Fix backwards pagination * Add hasPreviousPage
Cleanup configuration
…lias Configure formats provider interface autowiring alias
* Avoid to call serialize in ItemNormalizer * Allow composite identifiers in getItemIriFromResourceClass
lyrixx
force-pushed
the
ensure-verbe-is-uppercase
branch
from
182cdab
to
b219add
Compare
|
Could you add a test? |
teohhanhui
suggested changes
Apr 8, 2019
src/Metadata/Resource/Factory/OperationResourceMetadataFactory.php
Outdated
Show resolved
Hide resolved
|
Can't we just convert the HTTP method to uppercase, since that's what they should be in anyway? |
If you think this is a good approach, let's do it. I will update the PR |
lyrixx
force-pushed
the
ensure-verbe-is-uppercase
branch
from
0a21e6b
to
28369bb
Compare
lyrixx
changed the title
lyrixx
force-pushed
the
ensure-verbe-is-uppercase
branch
2 times, most recently
from
47b2e43
to
843e491
Compare
|
PR Updated |
teohhanhui
suggested changes
Apr 8, 2019
| @@ -123,6 +123,8 @@ private function normalize(bool $collection, ResourceMetadata $resourceMetadata, | |||
| $supported ? $operation['method'] = $upperOperationName : $operation['route_name'] = $operationName; | |||
| } | |||
|
|
|||
| $operation['method'] = strtoupper($operation['method']); | |||
There was a problem hiding this comment.
This does not seem correct to me. $operation['method'] might not be set.
Anyway, this part of the code could probably use some refactoring. $upperOperationName is... weird. 🙈
lyrixx
force-pushed
the
ensure-verbe-is-uppercase
branch
from
843e491
to
637e4c2
Compare
dunglas
approved these changes
Apr 15, 2019
teohhanhui
approved these changes
Apr 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.