Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate OIS title #293

Closed
bbenligiray opened this issue Apr 20, 2021 · 5 comments
Closed

Validate OIS title #293

bbenligiray opened this issue Apr 20, 2021 · 5 comments
Assignees
@wkande @drgy
Labels
documentation Improvements or additions to documentation validator About the @airnode/validator package

Comments

@bbenligiray
Copy link
Member

bbenligiray commented Apr 20, 2021 •
edited by sync-by-unito bot
Loading

OIS title isn't validated but it should be

airnode/packages/validator/templates/ois.json

Line 5 in c3ffc8d

"title": {},

Waiting on the discussion at ChainAPI to be resolved for what is allowed
@bbenligiray bbenligiray added the validator About the @airnode/validator package label Apr 20, 2021
@bbenligiray bbenligiray mentioned this issue Apr 20, 2021
Closed
@bbenligiray bbenligiray added the documentation Improvements or additions to documentation label Apr 23, 2021
@bbenligiray
Copy link
Member Author

bbenligiray commented Apr 23, 2021 •
edited
Loading

Title field is at most 32 64 characters, can only include alphanumeric characters, hyphen, underscore, whitespace
@drgy can you please update the template and @wkande can you add it to OIS docs please?

@drgy
Copy link
Contributor

drgy commented Apr 23, 2021

Updated in af5e4eb

@bbenligiray
Copy link
Member Author

Actually 32 is too short, let's make this 64

@wkande
Copy link
Member

wkande commented Aug 5, 2021 •
edited by bbenligiray
Loading

Added both to /pre-alpha and /next. See docs.api3.org/next/reference/specifications/ois.html#_1-oisformat

From api3-docs issue: api3dao/old-api3-docs#60

2. title

(Required) The OIS title. Title field is at most 64 characters, can only include alphanumeric characters, hyphens, underscores and whitespaces.

OAS equivalent: info.title

@bbenligiray
Copy link
Member Author

Thanks @wkande !

@bbenligiray bbenligiray mentioned this issue Aug 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wkande wkande

@drgy drgy

Labels
documentation Improvements or additions to documentation validator About the @airnode/validator package
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wkande @drgy @bbenligiray