fix: add twine to upload to PyPi #162
Conversation
| @@ -119,5 +119,5 @@ def release(): | |||
| sh("git tag -s '%(name)s-%(version)s' -m 'Version bump to %(version)s'" % {'name': NAME, 'version': VERSION}) | |||
| sh("git push --tags") | |||
| sh("git push") | |||
| sh("python setup.py register sdist upload") | |||
There was a problem hiding this comment.
I’m not completely sure whether we should remove register. Is it deprecated as well?
There was a problem hiding this comment.
I'm not sure but works without that. But we have already register. I will get this back.
There was a problem hiding this comment.
Fixed, I added register back.
There was a problem hiding this comment.
It's true the register is only needed once...
abtris
force-pushed
the
abtris/add-twine
branch
from
4e0d4cf
to
664ebe8
Compare
pavement.py
Outdated
| @@ -119,5 +119,5 @@ def release(): | |||
| sh("git tag -s '%(name)s-%(version)s' -m 'Version bump to %(version)s'" % {'name': NAME, 'version': VERSION}) | |||
| sh("git push --tags") | |||
| sh("git push") | |||
| sh("python setup.py register sdist upload") | |||
| sh("python setup.py bdist_wheel upload") | |||
| sh("python setup.py register sdist bdist_wheel") | |||
There was a problem hiding this comment.
@honzajavorek is right and we don't need register. I'm doing similar:
version = self.determine_current_version()
invoke(['python', 'setup.py', 'sdist', 'bdist_wheel'])
invoke(['twine', 'upload', 'dist/*{}*'.format(version)])There was a problem hiding this comment.
I wasn't right, because first I made @abtris to put register back 😄
pavement.py
Outdated
| sh("python setup.py register sdist upload") | ||
| sh("python setup.py bdist_wheel upload") | ||
| sh("python setup.py register sdist bdist_wheel") | ||
| sh("twine upload dist/*") |
There was a problem hiding this comment.
Maybe a better idea to make this dist/*{version}* so we don't re-upload old versions of mistakenly upload wrong versions.
abtris
force-pushed
the
abtris/add-twine
branch
from
664ebe8
to
c9f7f51
Compare
|
@kylef updated |
|
Pls, re-review. |
This can solve #161
Used steps from https://pypi.org/project/twine/