Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drafter version does not work for CMake builds #775

Closed
kylef opened this issue Mar 16, 2020 · 0 comments
Closed

Drafter version does not work for CMake builds #775

kylef opened this issue Mar 16, 2020 · 0 comments
Labels

Comments

@kylef
Copy link
Member

kylef commented Mar 16, 2020

When building with CMake, the version is returned as "Non-oficial drafter gyp-based build", which is incorrect.

$ ./src/drafter --version
Non-oficial drafter gyp-based build

It would look like the code here is incorrect, and designed so that it checks for the presence of a macro CMAKE_BUILD_TYPE, which I don't think is ever set and thus always returns GYP version.

#if defined CMAKE_BUILD_TYPE

@kylef kylef added the bug label Mar 16, 2020
klokane added a commit that referenced this issue Mar 16, 2020
klokane added a commit that referenced this issue Mar 16, 2020
klokane added a commit that referenced this issue Mar 16, 2020
kylef pushed a commit that referenced this issue Mar 16, 2020
kylef pushed a commit that referenced this issue Mar 16, 2020
@kylef kylef closed this as completed in d09d67b Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant