New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction ids are not unique and do not include expected status code #866

Closed
anth0d opened this Issue Aug 18, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@anth0d

anth0d commented Aug 18, 2017

Rationale

Execution of transactions is based on method, URI and status code, however, transaction ID for reporting is only comprised of method and URI. This obscures the behavior of Dredd and makes it harder for me to drive adoption to my teams.

So I'd like to add status code to the transaction ID (<method> <URI> becomes <method> (<status>) <URI>)

Current behavior


info: Successfully connected to hooks handler. Waiting 0.1s to start testing.
pass: POST /channelmapper/v1/channel duration: 25ms
skip: POST /channelmapper/v1/channel
skip: POST /channelmapper/v1/channel
pass: GET /v1/channel/9cd4342be duration: 25ms
skip: GET /v1/channel/9cd4342be
pass: GET /v1/channel/9cd4342be duration: 16ms

complete: 3 passing, 0 failing, 0 errors, 3 skipped, 6 total

Notice the test status code is not present.

Proposed:

info: Successfully connected to hooks handler. Waiting 0.1s to start testing.
pass: POST (204) /channelmapper/v1/channel duration: 25ms
skip: POST (401) /channelmapper/v1/channel
skip: POST (404) /channelmapper/v1/channel
pass: GET (200) /v1/channel/9cd4342be duration: 25ms
skip: GET (401) /v1/channel/9cd4342be
pass: GET (404) /v1/channel/9cd4342be duration: 16ms

complete: 3 passing, 0 failing, 0 errors, 3 skipped, 6 total

@honzajavorek

This comment has been minimized.

Show comment
Hide comment
@honzajavorek

honzajavorek Aug 18, 2017

Member

Hi, you are right! 🙌 The output doesn't help much. It's because the code for the reporting is there since the beginnings of Dredd and it did not catch up yet on many new features Dredd now has.

We have a proposal on how to revamp the output completely - #765. It would be awesome if you take a peek and drop your ideas there as well. I think what you propose here is a small change we can definitely do to improve the current situation 👍

Member

honzajavorek commented Aug 18, 2017

Hi, you are right! 🙌 The output doesn't help much. It's because the code for the reporting is there since the beginnings of Dredd and it did not catch up yet on many new features Dredd now has.

We have a proposal on how to revamp the output completely - #765. It would be awesome if you take a peek and drop your ideas there as well. I think what you propose here is a small change we can definitely do to improve the current situation 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment