New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status codes to test ID and Dredd output #868

Merged
merged 3 commits into from Aug 23, 2017

Conversation

Projects
None yet
2 participants
@anth0d

anth0d commented Aug 18, 2017

πŸš€ Why this change?

The primary reason for this change is that test IDs are non-unique and that makes test output hard to understand. This PR adds the (###) to the transaction ID so that a 200 is distinctly different from a 204, 401, 404, etc...

info: Successfully connected to hooks handler. Waiting 0.1s to start testing.
pass: POST (204) /channelmapper/v1/channel duration: 25ms
skip: POST (401) /channelmapper/v1/channel
skip: POST (404) /channelmapper/v1/channel
pass: GET (200) /v1/channel/9cd4342be duration: 25ms
skip: GET (401) /v1/channel/9cd4342be
pass: GET (404) /v1/channel/9cd4342be duration: 16ms

complete: 3 passing, 0 failing, 0 errors, 3 skipped, 6 total

πŸ“ Related issues and Pull Requests

βœ… What didn't I forget?

  • [βœ”] To write docs
  • [βœ”] To write tests
  • [βœ”] To put Conventional Changelog prefixes in front of all my commits and run npm run lint

@anth0d anth0d changed the title from Origin/other status codes to Add status codes to test ID and Dredd output Aug 18, 2017

@honzajavorek

Thanks for the PR! I think this is generally a good idea. See my comments.

The current format of the transaction ID is part of many tests, so those will need to be changed first. That's why tests on both Windows (AppVeyor) and Linux (Travis CI) failed.

I also suggest to update the example value for the transaction ID in Dredd's docs: https://dredd.readthedocs.io/en/latest/data-structures.html#transaction-object

Show outdated Hide outdated package.json
Show outdated Hide outdated package.json
@honzajavorek

This comment has been minimized.

Show comment
Hide comment
@honzajavorek

honzajavorek Aug 18, 2017

Member
Member

honzajavorek commented Aug 18, 2017

@anth0d

This comment has been minimized.

Show comment
Hide comment
@anth0d

anth0d Aug 18, 2017

@honzajavorek I've made the changes you requested - but unfortunately the Travis CI build failed - I am trying to reproduce but having no success. The failing tests are here and here if you have any tips for how to debug.

anth0d commented Aug 18, 2017

@honzajavorek I've made the changes you requested - but unfortunately the Travis CI build failed - I am trying to reproduce but having no success. The failing tests are here and here if you have any tips for how to debug.

@anth0d anth0d closed this Aug 18, 2017

@anth0d anth0d reopened this Aug 18, 2017

@honzajavorek

This comment has been minimized.

Show comment
Hide comment
@honzajavorek

honzajavorek Aug 21, 2017

Member

@antkazam I see all builds passing on the last commit. I guess you figured it out then? I'll get back shortly to do review.

Member

honzajavorek commented Aug 21, 2017

@antkazam I see all builds passing on the last commit. I guess you figured it out then? I'll get back shortly to do review.

@honzajavorek

This comment has been minimized.

Show comment
Hide comment
@honzajavorek

honzajavorek Aug 21, 2017

Member

Just a nitpick from looking at the commits, you may want to fix your git or GitHub email settings to have your authorship correctly associated:

image

Only noting for your own good, this by no means blocks the PR.

Member

honzajavorek commented Aug 21, 2017

Just a nitpick from looking at the commits, you may want to fix your git or GitHub email settings to have your authorship correctly associated:

image

Only noting for your own good, this by no means blocks the PR.

@honzajavorek

honzajavorek approved these changes Aug 21, 2017 edited

Looks great! πŸ‘ Thanks so much! ✨

I'm ready to merge this. I'll give you some time to figure out the email associations if you want (if you want to amend the previous commits and to change their email, you may want to rebase the branch before it gets merged) and possibly tomorrow I think I'll merge this πŸš€

@honzajavorek

This comment has been minimized.

Show comment
Hide comment
@honzajavorek

honzajavorek Aug 22, 2017

Member

This needs to wait until #872 gets fixed. We need to release a fix in patch so it auto-propagates to installations the same way as did the bug. Adding a feature would close the way to auto-propagate by bumping the minor version number.

Member

honzajavorek commented Aug 22, 2017

This needs to wait until #872 gets fixed. We need to release a fix in patch so it auto-propagates to installations the same way as did the bug. Adding a feature would close the way to auto-propagate by bumping the minor version number.

@honzajavorek honzajavorek merged commit ad06314 into apiaryio:master Aug 23, 2017

4 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 96.243%
Details
security/snyk No new vulnerabilities
Details
@anth0d

This comment has been minimized.

Show comment
Hide comment
@anth0d

anth0d Aug 23, 2017

Thanks @honzajavorek I was out of town until now. Really appreciate your help.

anth0d commented Aug 23, 2017

Thanks @honzajavorek I was out of town until now. Really appreciate your help.

@anth0d anth0d deleted the anth0d:origin/other-status-codes branch Aug 23, 2017

@honzajavorek

This comment has been minimized.

Show comment
Hide comment
@honzajavorek

honzajavorek Aug 23, 2017

Member

@antkazam Thanks for the PR! πŸ‘

Member

honzajavorek commented Aug 23, 2017

@antkazam Thanks for the PR! πŸ‘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment