Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add status codes to test ID and Dredd output #868
Thanks for the PR! I think this is generally a good idea. See my comments.
The current format of the transaction ID is part of many tests, so those will need to be changed first. That's why tests on both Windows (AppVeyor) and Linux (Travis CI) failed.
I also suggest to update the example value for the transaction ID in Dredd's docs: https://dredd.readthedocs.io/en/latest/data-structures.html#transaction-object
Yes, but that's better solved by releasing a fix. One fix is already out, the other one will follow shortly.…
On 18 Aug 2017, 17:03 +0200, Anthony Davis ***@***.***>, wrote: @antkazam commented on this pull request. In package.json: > @@ -35,7 +36,7 @@ "coffee-script": "^1.12.5", "colors": "^1.1.2", "cross-spawn": "^5.0.1", - "dredd-transactions": "^4.3.0", + "dredd-transactions": "4.2.0", Sorry I thought I linked the issue. Currently the latest version of dredd-transactions has an issue introduced by one of its dependencies - apiaryio/dredd-transactions#93 — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.
I'm ready to merge this. I'll give you some time to figure out the email associations if you want (if you want to amend the previous commits and to change their email, you may want to rebase the branch before it gets merged) and possibly tomorrow I think I'll merge this