Apiary reporter not throwing anymore, only passing error to callback #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@netmilk ... possibly squash to single commit? Or two commits one from miiila and one from you? |
netmilk
force-pushed
the
miiila/return-authentication-error-via-js-api
branch
from
591781c
to
a393509
Compare
netmilk
changed the title
|
@WVI, squashed.
|
|
@netmilk approved! |
w-vi
added a commit
that referenced
this pull request
Sep 21, 2015
…ror-via-js-api Apiary reporter not throwing anymore, only passing error to callback
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing _performRequestAsync to return callback filled with an error instead of fatal error in Apiary reporter.
Introduced change is triggered by need of assertion failure just after reporter start.