Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguous parameters raise exception (fix) #484

Merged
merged 9 commits into from
May 17, 2016

Conversation

honzajavorek
Copy link
Contributor

@honzajavorek honzajavorek commented May 13, 2016

  1. Fixes Undocumented parameters raise an exception #469 and fixes Cannot read property 'replace' of null #478.
  2. Some "on the way" clean up work attached (linter, whitespace, redundant files).

I suggest to review commit-by-commit. It should be easy reading. The 1. takes single line and the rest is just cleanup.

@@ -31,7 +31,7 @@
"chai": "^3.4.1",
"clone": "^1.0.0",
"coffee-script": "^1.9.1",
"dredd-transactions": "0.0.4",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the main change in this PR, actually.

@honzajavorek
Copy link
Contributor Author

Coverage drop is probably due to removal of files and corresponding tests. There's nothing to cover in this PR.

@freaz freaz self-assigned this May 17, 2016
@honzajavorek honzajavorek force-pushed the honzajavorek/ambiguous-parameters-raise-exception branch from d0e5669 to 09fbbe5 Compare May 17, 2016 12:13
@freaz freaz merged commit 22c0293 into master May 17, 2016
@honzajavorek honzajavorek deleted the honzajavorek/ambiguous-parameters-raise-exception branch May 17, 2016 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read property 'replace' of null Undocumented parameters raise an exception
2 participants