New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTPS support, global header injection, improved reporter output #5
Conversation
I had to add /lib to the project so that it could actually be used in other projects. Am I missing something? Should I revert those commits? |
Hi Evan,
Please revert all commits regarding Thanks again for the bunch of awesome work! All the best |
Just one note about the headers inkjection. Headers and parameters injection (top to bottom inheritance) should be part of the API Blueprint format. You will be able to define some global headers and parameters in the API Name & Overview Section like tokens, paging or sorting. For this moment I see headers injection on the Dredd level as very useful. Especially for purpose of HTTP basic authentication. A |
…compiling" and "Adds /lib" This reverts commit e3d0280.
Reverted the /lib stuff. I was trying to point npm to a branch on my fork of dredd so that I could test it in production. For whatever reason that doesn't actually build the library, so I mistakenly thought to add the compiled source. As for the headers: I saw that the spec supports inheriting headers, but that doesn't help when you need to generate the header dynamically (for sessions or auth or something else). Thanks! |
Evan, |
HTTPS support, global header injection, improved reporter output
Added .gitattributes so users of the package don't have unnecessary a…
Implement cucumber tests
Fixed the Coveralls badge
Parsing of API description documents
This pull request does a few things:
This might be enough to support basic auth (#3), though I haven't tried it, and you'd need to construct the Authorization header yourself and pass it in (username:password encoded in base64). I only needed https and custom headers, so that's all I added.
I'm using bamboo's Junit Parser as the template for the junit reporter's output, and have made some changes to improve that as well.
Coverage went down just a bit :/ but it's still pretty good!
I plan to remove the cli library from everything but bin/dredd and use another logger internally. Using cli everywhere has made it so that passing in silent or debug flags when consuming dredd in another app doesn't work. Plus using something like winston means you could have custom log levels. That will be a separate pull request though!