C# follow up #35
Merged
C# follow up #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@XVincentX Please use "zero" base indentation for the code block, or otherwise it will be indented everywhere. It is not needed. |
XVincentX
force-pushed
the
XVincentX/followupCsharp
branch
from
c32f4d3
to
18cc225
Compare
| } | ||
| <% if @method in ['GET', 'DELETE', 'OPTIONS', 'HEAD']: %> | ||
| <% if @method is 'HEAD': %> | ||
| var requestUri = new Uri(baseAddress, "<%- @url.substring(1) %>"); |
There was a problem hiding this comment.
Please always use <%= when printing user-input data.
For all <%- @url.substring(1) %> in lines below too, please. @XVincentX
XVincentX
force-pushed
the
XVincentX/followupCsharp
branch
from
18cc225
to
c8fcf4b
Compare
kuba-kubula
added a commit
that referenced
this pull request
Jan 19, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another follow up due to rebase and automated test using Mono.