Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove json_ and order_no from Request #94

Open
janbuchar opened this issue Apr 8, 2024 · 2 comments
Open

Remove json_ and order_no from Request #94

janbuchar opened this issue Apr 8, 2024 · 2 comments
Labels
debt Code quality improvement or decrease of technical debt. t-tooling Issues with this label are in the ownership of the tooling team.

Comments

@janbuchar
Copy link
Collaborator

janbuchar commented Apr 8, 2024 •
edited
Loading

The purpose of the fields is somewhat unclear, but it's certain that they don't belong to the Request class.

We should definitely explore the notion of an internal request in Crawlee and how it translates to the Python version.
@janbuchar janbuchar added t-tooling Issues with this label are in the ownership of the tooling team. debt Code quality improvement or decrease of technical debt. labels Apr 8, 2024
@janbuchar janbuchar mentioned this issue Apr 17, 2024
Closed
@vdusek vdusek added this to the 0.2 milestone Jun 10, 2024
@vdusek vdusek removed this from the v0.2 milestone Jul 15, 2024
@janbuchar janbuchar mentioned this issue Aug 15, 2024
Open
@janbuchar janbuchar mentioned this issue Sep 23, 2024
Merged
@janbuchar
Copy link
Collaborator Author

Also, the mechanism of determining an ID based on unique key should be exclusive to memory storage (internal request). So Request.id should only ever be populated by loading an API response.

Otherwise, things like #623 will happen.

@janbuchar janbuchar mentioned this issue Oct 25, 2024
Merged
@janbuchar
Copy link
Collaborator Author

Frankly, I don't think that there's any excuse for a request ID that's derived from a unique key. Maybe it has something to do with file path safety...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
debt Code quality improvement or decrease of technical debt. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@janbuchar @vdusek