fix: key value stores emitting an error when multiple write promises ran in parallel #1460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about using locks instead? |
|
Well, the bulk of the issues happen because we purge the old data in the background, if we'd await it I doubt we'd have any issues, but well... then it could take seconds of waiting and not "doing anything" |
|
Seconds would be fine, but it could took half a minute easily, that dx sucks without any progress bar. But I would say locking can help. First lock the folder, then move it and schedule removal. If locking it fails (second promise), you dont even try to do anything. |
vladfrangu
changed the title
B4nan
approved these changes
Aug 12, 2022
|
Needs manual rebase, sorry, forgot to merge it before bumping the version. |
|
Will do, sec |
I tried this locally and haven't encountered any errors over tens of retries... I guess the solution is sometimes going sync instead of async 😢
vladfrangu
force-pushed
the
fix/possibly-lower-the-rate-of-errors-for-memory-storage-cleanup
branch
from
f2c1a30
to
3a09366
Compare
B4nan
deleted the
fix/possibly-lower-the-rate-of-errors-for-memory-storage-cleanup
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should make #1435 less probable (or outright fix it), however, as I have been unable to consistently replicate the issue mentioned (i can replicate it ~ once every 10-15 tries), this is still in the airFixes #1435