-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use JSON5 for INPUT.json #1538
Conversation
Could add a test in packages/core/test/user-input.test.ts for inputs with comments 👀 |
We should probably move this to some other place. Right now you adjusted this only for crawlee ( I would be in favour of doing this in the memory storage too, thoughts @vladfrangu? edit: for input only I guess, or maybe for KVS, definitely not for dataset and RQ |
If we want to add full JSON5 support, we should probably use https://github.com/json5/json5 or similar then. Could see it being useful for others dealing with JSON files, and I'd be fine with adding support for it in memory-storage |
Can you please verify how does it stand performance wise? I guess I would be up for it, just checked the size of crawlee package, and I guess there is no sense is trying to spare 200 kilobytes when its so huge :D |
Added an E2E test for |
Fixes #905