feat: don't close page before calling errorHandler

[szmarczak]

No description provided.

[B4nan]

should this resolve #947 or do we need something else too? i dont see the closes #... here

[szmarczak]

Depends on whether it includes errorHandler to be called on each error instead of retry. I'm wondering if that would be breaking.

Otherwise feel free to add the Closes.

[B4nan]

Depends on whether it includes errorHandler to be called on each error instead of retry. I'm wondering if that would be breaking.

No plans to release that as breaking, it will be a patch bump, and if its not there, please do so (ideally it should be separate PR so we have separate line in changelog).

[B4nan]

I was expecting that separate PR first, and tagging this issue with closes #..., before we merge it, so we have it propertly written in the changelog. We need to care more about what we merge and how the git history in master look like, as it will directly affect the changelog once we fully automate the releasing process.

[szmarczak]

I was expecting that separate PR first

Why is that?

tagging this issue with closes #...

It doesn't make sense to close the issue if the other future PR is also a part of that issue, no?

[B4nan]

This PR is technically fixing #947, isnt it? But it wont be linked in the generated changelog to this issue, that's why.

It doesn't make sense to close the issue if the other future PR is also a part of that issue, no?

Exactly, and that is why I was expecting the fix to come first. It will be a one liner, or no?

Anyway, not a big deal, and it does not matter much as its merged already. My main message was - let's try to think more about how the master git history looks like, as it will be used for generated changelog. And we want to link issues in the changelog description.