Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: RequestList has invalid URL regexp #99

Closed
jancurn opened this issue May 16, 2018 · 3 comments
Closed

BUG: RequestList has invalid URL regexp #99

jancurn opened this issue May 16, 2018 · 3 comments
Labels
bug Something isn't working.

Comments

@jancurn
Copy link
Member

jancurn commented May 16, 2018

When it goes through file like:

AAA,BBB,"https://www.example.com/bla,bla"

It identifies URL:

https://www.example.com/bla,bla"

(note the quote). IMHO the parser should ignore unsafe URL characters (https://perishablepress.com/stop-using-unsafe-characters-in-urls/)

@jancurn
Copy link
Member Author

jancurn commented May 16, 2018

This should be fixed together with issue #65

@mtrunkat mtrunkat added the bug Something isn't working. label Jun 7, 2018
@jancurn
Copy link
Member Author

jancurn commented Jul 19, 2018

Another customer complained about this, we need to fix this asap, plus add proper unit tests. Issue #65 can wait, this one cannot.

@mtrunkat
Copy link
Member

Fix merged, will be included in upcoming release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working.
Projects
None yet
Development

No branches or pull requests

2 participants