Properly handle JSON String values for object type

[krivin]

When doing type conversion for strings when the expected type is object and the string contains a JSON encoded object, it is not converted to object.

This breaks response validation in swagger-restify, which sets up connect middleware, which passes the body of the response to the validator as a string: https://github.com/theganyo/swagger-node-runner/blob/master/lib/connect_middleware.js#L162. I can't see what else it can do, and it would have worked before 473c6db.

[whitlockjc]

Ironically, the reason this feature was removed was because of swagger-node-runner. What version of swagger-node-runner are you running? If it's not the latest, do you mind upgrading and trying with sway as-is? Let me know what you find out.

[krivin]

It is the latest. Just spent the day fixing npm update issues :-)

─┬ swagger-restify-mw@0.6.0
└─┬ swagger-node-runner@0.6.13
├─┬ sway@0.6.0

[whitlockjc]

Okay. I don't see why we can't just add this back and resurrect its tests but I'd love to let @theganyo chime in first.

[whitlockjc]

Also, if you don't mind could you create an issue in swagger-node-runner for this as well, for posterity? Link this issue in the issue description so that @theganyo has context.

[theganyo]

I don't recall any specific reason from prior discussions why this feature was removed. The only discussions I'm remembering were around not parsing when the type was indeterminate. But maybe I'm forgetting something?

[whitlockjc]

Could be. Maybe too much was removed. I'll add it back so that when we know the type is object and the value is a string, we try to parse it. We should do the same for arrays.