Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client Credentials Grant Type should also support Basic Authentication. EDIT - handling missing Content-Type header #55

Closed
seantdg opened this issue Oct 3, 2017 · 3 comments

Comments

@seantdg
Copy link

seantdg commented Oct 3, 2017

Many PSPs will only support Basic Authentication for the Client Credentials grant type /token call, instead of a client assertion.

Could we support this too? Currently if I pass a normal /token request with client credentials, the refresh token policy is hit instead of an error.

@rohan-m
Copy link
Member

rohan-m commented Oct 4, 2017

@seantdg
Both basic authentication and client assertion are supported.
Currently if you pass basic auth, it should generate access token and not produce error.
Looks like a policy in the flow is missed and refresh token is hit directly in your scenario..
Can you provide the error you are facing with more detail?

@seantdg
Copy link
Author

seantdg commented Oct 5, 2017

my mistake! this occurs if the Content-Type header isn't set correctly. We should either assume a Content-Type of "application/x-www-form-urlencoded" if a Content-Type isn't set, or throw an error rather than assuming refresh token.

@seantdg seantdg changed the title Client Credentials Grant Type should also support Basic Authentication. Client Credentials Grant Type should also support Basic Authentication. EDIT - handling missing Content-Type header Oct 5, 2017
@laughingbiscuit
Copy link
Contributor

Closing as the project has been refactored and this bug issue no longer applies - please see https://github.com/apigee/openbank#previous-versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants