Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race condition causes static file uploads to fail with an HTTP adapter #82

Closed
gbrail opened this issue Sep 3, 2014 · 0 comments
Closed

Comments

@gbrail
Copy link
Contributor

gbrail commented Sep 3, 2014

A race condition causes file uploads using the "express.static()" middleware to fail for large-ish files when an HTTP adapter is used.

The root cause seems to be one of those wonderful issues where one of the many modules that make up connect (in this case it is called "on-finished" is introspecting on the HTTP request and response objects and looking for various fields such as "finished") is assuming that it is using regular Node code.

The solution is to make our HTTP adapter have more of those special internal fields.

@gbrail gbrail added bug labels Sep 4, 2014
@gbrail gbrail closed this as completed Sep 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant