-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable the user to feed an existing configuration file #8
Comments
@aveuiller what about specifying the path to existing config file, without parsing. See this. |
That's already what we are doing in the end, so yes ultimately we don't have to parse the configuration file. Having said that, the embedded influx server is made to automatically remove the created data directory on server stop (hence the I don't really like both of the solutions since it duplicate the What do you think about it? |
@aveuiller I think to let a user choose when to delete data, it's a nice option. |
As mentioned by @fsanaulla in #6, we should propose a
ConfigurationWriter
implementation able to use an existing influx config file.I think in this case the methods should have the following behaviour:
addStatement
: Throw anUnsupportedOperationException
.writeFile
: Return the user given config file.getDataPath
: The main difficulty here since we should parse the given configuration file to retrieve the data path. And even if our configuration centralize all the data in a directory, the user defined configuration may come with multiple data directory.Maybe we should give the option to the user to set a data directory to remove on server stop? This would avoid us to parse the given configuration file.
The text was updated successfully, but these errors were encountered: