Skip to content

Commit

Permalink
Revert "qapitrace: fix an inline string FIXME request"
Browse files Browse the repository at this point in the history
This reverts commit 0d86efd, from
issue #244, due to two problems I just noticed:

- strcasestr doesn't exist on Windows, and there seems to be no easy
  replacement.

- ApiTraceCall::contains search the string in the whole call (not just
  the name)
  • Loading branch information
jrfonseca committed Mar 27, 2014
1 parent 0d86efd commit cb7c76f
Showing 1 changed file with 8 additions and 5 deletions.
13 changes: 8 additions & 5 deletions gui/traceloader.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -406,11 +406,14 @@ bool TraceLoader::callContains(trace::Call *call,
const QString &str,
Qt::CaseSensitivity sensitivity)
{
if (sensitivity == Qt::CaseSensitive) {
return (bool) strstr (call->name(), str.toAscii().data());
} else {
return (bool) strcasestr (call->name(), str.toAscii().data());
}
/*
* FIXME: do string comparison directly on trace::Call
*/
ApiTraceCall *apiCall = apiCallFromTraceCall(call, m_helpHash,
0, 0, this);
bool result = apiCall->contains(str, sensitivity);
delete apiCall;
return result;
}

QVector<ApiTraceCall*>
Expand Down

0 comments on commit cb7c76f

Please sign in to comment.