-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multiple chapters in one file #15
Comments
This is a good idea... receive the volume and not each chapter. |
Doing it by volume would only work if the source gave that information which most don't. But I totally agree, there should be a way to bundle the chapters together before being sent, especially when there are more and more mangas with very short chapters - the ridiculously named "A Story About Treating a Female Knight Who Has Never Been Treated as a Woman as a Woman" for example has usually 4-8 pages per 'chapter'. |
There is a limit, tho, as amazon have a size limit for documents send by email. Also @JohnEdwa is right, most of the sites do not provide volume information, or provide it in random ways (partially hinted in the name of the chapter) I can sacrifice cache reuse in favor of conglomerating several chapters, but to make it practical (no surpassing the size limit) I need first to decrease the weight of each image. Overall this makes sense to me, but this will require some time. |
It would make sense to swap the hardcoded 30 sends/day limit to mo of a 'credit' system where what and how you send makes a difference depending on how intensive it is. |
@JohnEdwa that is a very interesting proposal. The limit is there because the server have some limitations. So is not fair consider a 30 pages chapter the same as a 10 pages one. But I can see a big issue. One is that this is very hard to communicate to the user, as kmanga have no clue about the size of the chapter (and knowing it before hand will impose a big load to the original source, as I need to make at least one more request per chapter, per manga, per site) If I use some kind of 'you have 5M of images for today' is a bit fuzzy measure, as this limit can be from the input (before the image is resized), for computing (during the resize) or for output (once the MOBI is created) But I will think more about this idea. |
Hmmmh, true, the lack of information is an issue. I think basing it on the before sizes would be the fastest as that way you can detect when something is going to be too much the moment you've downloaded enough chapters without having to process them. The point is, after all, to get a reasonable amount of chapters into one file and not a 'who gets closest to 49.999MB' competition. As for how to handle the credits, one way I thought of handling the ambiguity could be allowing storing and going negative up to some reasonable limits, as most people have multiple days without having anything sent after all. |
Having hundreds of chapters in a kindle becomes very difficult to handle. Sending them in ranges would make a lot of sense for longer series.
The text was updated successfully, but these errors were encountered: