0.9.0 (7) - Changes to Data Transport #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phryneas
force-pushed
the
pr/adjust-datatransport
branch
from
42ea24a
to
81e2d4e
Compare
|
I think this is ready for review now :) |
phryneas
commented
Mar 6, 2024
Comment on lines
74
to
102
| const streamObservable = new Observable< | ||
| Exclude<QueryEvent, { type: "started" }> | ||
| >((subscriber) => { | ||
| const { markResult, markError, markReady } = queryInfo; | ||
| queryInfo.markResult = function (result: FetchResult<any>) { | ||
| subscriber.next({ | ||
| type: "data", | ||
| id, | ||
| result: result, | ||
| }); | ||
| return markResult.apply(queryInfo, arguments as any); | ||
| }; | ||
| queryInfo.markError = function () { | ||
| subscriber.next({ | ||
| type: "error", | ||
| id, | ||
| }); | ||
| subscriber.complete(); | ||
| return markError.apply(queryInfo, arguments as any); | ||
| }; | ||
| queryInfo.markReady = function () { | ||
| subscriber.next({ | ||
| type: "complete", | ||
| id, | ||
| }); | ||
| subscriber.complete(); | ||
| return markReady.apply(queryInfo, arguments as any); | ||
| }; | ||
| }); |
There was a problem hiding this comment.
If someone has a better idea how to tap into link data events instead of wrapping queryInfo functions, I'm all ears. This is the best I could come up with.
Job #14: Bundle Size — 1MiB (+0.76%).Warning Bundle contains 1 duplicate package – View duplicate packages Warning Bundle introduced one new package: react-error-boundary – View changed packages Bundle metrics
 
Bundle size by type
View job #14 report View pr/adjust-datatransport branch activity View project dashboard |
jerelmiller
approved these changes
Mar 12, 2024
packages/client-react-streaming/src/DataTransportAbstraction/WrappedApolloClient.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
74
to
102
| const streamObservable = new Observable< | ||
| Exclude<QueryEvent, { type: "started" }> | ||
| >((subscriber) => { | ||
| const { markResult, markError, markReady } = queryInfo; | ||
| queryInfo.markResult = function (result: FetchResult<any>) { | ||
| subscriber.next({ | ||
| type: "data", | ||
| id, | ||
| result: result, | ||
| }); | ||
| return markResult.apply(queryInfo, arguments as any); | ||
| }; | ||
| queryInfo.markError = function () { | ||
| subscriber.next({ | ||
| type: "error", | ||
| id, | ||
| }); | ||
| subscriber.complete(); | ||
| return markError.apply(queryInfo, arguments as any); | ||
| }; | ||
| queryInfo.markReady = function () { | ||
| subscriber.next({ | ||
| type: "complete", | ||
| id, | ||
| }); | ||
| subscriber.complete(); | ||
| return markReady.apply(queryInfo, arguments as any); | ||
| }; | ||
| }); |
…rappedApolloClient.tsx Co-authored-by: Jerel Miller <jerelmiller@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I don't want to change the shape of the DataTransportAbstraction immediately after we released it for the first time, this one would also need to go into 0.9.0.
This switches from two very separate "request started" and "request finished" events to a stream of events with a shared identifier between queries.
This has the benefit that in the future we can easily track which events are still "unhandled", e.g. for keeping the connection open for longer.
Also, for the first time we detect & communicate errors that happened in SSR to the browser, to restart queries there immediately.
As a positive side-effect of having a "query identifier", the query document is sent only once, not twice over. That already plays a bit into #210.
(Technically, it's sent one more time per hook, so we're down from three times to two).