Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing utilities] Performance test against a large schema #11711

Closed
alessbell opened this issue Mar 20, 2024 · 3 comments
Closed

[Testing utilities] Performance test against a large schema #11711

alessbell opened this issue Mar 20, 2024 · 3 comments

Comments

@alessbell
Copy link
Member

Issue Description

We will likely need to introduce caching when creating the mock schema (see #11705 (comment)).

Link to Reproduction

N/A

Reproduction Steps

No response

@apollo/client version

N/A

@alessbell
Copy link
Member Author

createMockSchema has performed well with the fairly large Spotify schema when testing with the Spotify Showcase. That combined with the fact that it will likely only be called once during test setup (unlike createProxiedSchema) is enough for me to justify closing this for now, until an actual performance problem is felt, at while point I'll be happy to re-open and investigate.

Copy link
Contributor

github-actions bot commented Apr 5, 2024

Do you have any feedback for the maintainers? Please tell us by taking a one-minute survey. Your responses will help us understand Apollo Client usage and allow us to serve you better.

Copy link
Contributor

github-actions bot commented May 6, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
For general questions, we recommend using StackOverflow or our discord server.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant