Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding graphql-tag-swc-plugin to performance docs for apollo client #11872

Closed
rishabh3112 opened this issue May 30, 2024 · 5 comments · Fixed by #11884
Closed

Adding graphql-tag-swc-plugin to performance docs for apollo client #11872

rishabh3112 opened this issue May 30, 2024 · 5 comments · Fixed by #11884
Labels
🏓 awaiting-team-response requires input from the apollo team 📝 documentation

Comments

@rishabh3112
Copy link
Contributor

Hi there,
I am author of graphql-tag-swc-plugin which is essentially swc port for babel-plugin-graphql-tag.

I am proposing to add this to Performance docs of Apollo Client here: https://www.apollographql.com/docs/react/performance/babel . If this is a welcoming addition, I happy to raise PR for the same.

For context, This is being used on a large enterprise project ( ~20k entry point ) for past 5 - 6 months w/o issues.

Thanks!

@jerelmiller
Copy link
Member

Hey @rishabh3112 👋

Let me take this to the team to chat about it and I'll get back to you. Thanks for letting us know about it!

@jerelmiller jerelmiller added 🏓 awaiting-team-response requires input from the apollo team 📝 documentation labels May 30, 2024
@jerelmiller
Copy link
Member

@rishabh3112 we've discussed as a team and have no issues introducing this to our docs. If you'd like to open a PR, we'd welcome it. Thanks so much!

@rishabh3112
Copy link
Contributor Author

@jerelmiller created PR, please check : #11884

Copy link
Contributor

Do you have any feedback for the maintainers? Please tell us by taking a one-minute survey. Your responses will help us understand Apollo Client usage and allow us to serve you better.

Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
For general questions, we recommend using StackOverflow or our discord server.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🏓 awaiting-team-response requires input from the apollo team 📝 documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants