Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent QueryInfo#markResult mutation of result.data and return cache data consistently whether complete or incomplete #11202

Merged
merged 8 commits into from
Sep 14, 2023
Merged

Prevent QueryInfo#markResult mutation of result.data and return cache data consistently whether complete or incomplete #11202

merged 8 commits into from
Sep 14, 2023

Commits on Sep 13, 2023

  1. Avoid destructively modifying result.data in QueryInfo#markResult. 

    Should help with #9293.
    @benjamn
    benjamn committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    5e8b5e0 View commit details
    Browse the repository at this point in the history

  2. Test adjustments after fixing QueryInfo#markResult. 

    Most of these test tweaks are reasonable improvements necessitated by
fixing a bug that allowed queries to receive raw network results with
extraneous fields when the results were incomplete. Now, the extraneous
fields are no longer delivered, since they were not requested.

The test I removed completely does not make sense, and was only passing
previously because of the mock link running out of results.
    @benjamn
    benjamn committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    7f9c5ac View commit details
    Browse the repository at this point in the history

  3. New test of re-reading incomplete network results from cache.

    @benjamn
    benjamn committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    a201111 View commit details
    Browse the repository at this point in the history

  4. Run 'npx changeset' for PR #11202.

    @benjamn
    benjamn committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    7c2bc08 View commit details
    Browse the repository at this point in the history

  5. Run 'npm run format' for code modified in PR #11202.

    @benjamn
    benjamn committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    a031860 View commit details
    Browse the repository at this point in the history

  6. Bump size-limit +8 bytes.

    @benjamn
    benjamn committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    d8c6072 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. extend test to distinguish between cache & network

    @phryneas
    phryneas committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    2ad8485 View commit details
    Browse the repository at this point in the history

  2. defensive copy of result at the top of markResult

    @phryneas
    phryneas committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    ec5d86c View commit details
    Browse the repository at this point in the history